Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix bug] [One-line PR] Fix call of proxy.get_max_reward() #310

Merged
merged 1 commit into from
May 31, 2024
Merged

[Fix bug] [One-line PR] Fix call of proxy.get_max_reward() #310

merged 1 commit into from
May 31, 2024

Conversation

alexhernandezgarcia
Copy link
Owner

I don't know how this escaped my sanity check runs but it did.

carriepl
carriepl approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@carriepl carriepl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeahhhh.... we're going to need additional unit tests for this...

Just kidding! Gotta love a PR that only takes 3 seconds to review.

@carriepl carriepl merged commit 72f961b into main May 31, 2024
1 check passed
@carriepl carriepl deleted the fix-gfn-get-max-reward branch May 31, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carriepl carriepl carriepl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexhernandezgarcia @carriepl