-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Crystals plots icml24 #329
Open
AlexandraVolokhova
wants to merge
14
commits into
main
Choose a base branch
from
crystals-plots-icml24
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss_data_set) which now supports returning a CSV
alexhernandezgarcia
approved these changes
Jul 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't done an in-depth review but I have run the plots_icml24.py and made some changes (see commits). Things seem to work as expected! Thanks for the great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripts for plotting figures in the paper. Links to the updated plots are on Notion
Command to run plotting script for Fig 3, 11-14:
PYTHONPATH=/home/mila/a/alexandra.volokhova/projects/gflownet python plots_iclm24.py --pkl_path /home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_fe/samples/gfn_iter50k_samples.pkl --random_pkl_path /home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_fe/samples/randominit_samples.pkl --target eform --no_suptitles
Command to run plotting script for Fig 4:
PYTHONPATH=/home/mila/a/alexandra.volokhova/projects/gflownet python plots_iclm24.py --pkl_path /home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_bg/samples/gfn_iter50k_samples.pkl --random_pkl_path /home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_bg/samples/randominit_samples.pkl --target bandgap --no_suptitles
Command to run plotting script for Fig 15:
PYTHONPATH=/home/mila/a/alexandra.volokhova/projects/gflownet python plots_iclm24.py --pkl_path /home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_density/samples/gfn_iter50k_samples.pkl --random_pkl_path /home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_density/samples/randominit_samples.pkl --target density --no_suptitles
Command to get Fig 5:
PYTHONPATH=/home/mila/a/alexandra.volokhova/projects/gflownet python scripts/crystal/plots_conditional_icml24.py --pkl_path=/home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_fe/samples/gfn_iter50k_samples.pkl --cond_dir_root=/home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_fe_conditional
TODOs: