Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Crystals plots icml24 #329

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

AlexandraVolokhova
Copy link
Collaborator

@AlexandraVolokhova AlexandraVolokhova commented Jun 27, 2024

Scripts for plotting figures in the paper. Links to the updated plots are on Notion

Command to run plotting script for Fig 3, 11-14:
PYTHONPATH=/home/mila/a/alexandra.volokhova/projects/gflownet python plots_iclm24.py --pkl_path /home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_fe/samples/gfn_iter50k_samples.pkl --random_pkl_path /home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_fe/samples/randominit_samples.pkl --target eform --no_suptitles

Command to run plotting script for Fig 4:
PYTHONPATH=/home/mila/a/alexandra.volokhova/projects/gflownet python plots_iclm24.py --pkl_path /home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_bg/samples/gfn_iter50k_samples.pkl --random_pkl_path /home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_bg/samples/randominit_samples.pkl --target bandgap --no_suptitles

Command to run plotting script for Fig 15:
PYTHONPATH=/home/mila/a/alexandra.volokhova/projects/gflownet python plots_iclm24.py --pkl_path /home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_density/samples/gfn_iter50k_samples.pkl --random_pkl_path /home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_density/samples/randominit_samples.pkl --target density --no_suptitles

Command to get Fig 5:
PYTHONPATH=/home/mila/a/alexandra.volokhova/projects/gflownet python scripts/crystal/plots_conditional_icml24.py --pkl_path=/home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_fe/samples/gfn_iter50k_samples.pkl --cond_dir_root=/home/mila/a/alexandra.volokhova/projects/gflownet/external/starling_fe_conditional

TODOs:

  • Fig 3: Violins FE
  • Fig 4: Violins BG
  • Fig 5: Violins FE restricted (waiting for samples)
  • Fig 10: Ehall (@alexhernandezgarcia I couldn't find how it was plotted before, do you remember?)
  • Fig 11: Element frequencies FE
  • Fig 12: Element frequencies binary FE
  • Fig 13: SG FE
  • Fig 14: LP FE
  • Fig 15: Density
  • Check whether the correct dataset is used
  • Check that filtering gives the correct number of datapoints in the train and validation sets
  • Add densities to the train and validation data for violin plots for density

Copy link
Owner

@alexhernandezgarcia alexhernandezgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done an in-depth review but I have run the plots_icml24.py and made some changes (see commits). Things seem to work as expected! Thanks for the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants