Prevent unnecessary recalculation of proxy values #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
While the Batch kept track of the availability of rewards and log-rewards, it did not store the proxy values, which are not needed for the computation of the loss. However, the proxy values were (re-)computed for logging purposes and for the Buffer. This was a waste of computation, especially if the proxy is expensive.
Main changes
proxy.rewards()
now allows returning the proxy values, alongside the rewards, ifreturn_proxy
is True.Other changes