Fix CI crashing with test_spacegroup #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carriepl
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Looks good to me although I am not aware of everything that could break as a result of these changes. AFAIK it's fine but I don't know for a fact.
Also, interestingly, another test is failing here related to the batch class. To me, it seems unrelated to the current PR so it shouldn't stop the merge. But we should look at what test it is, what the problem is (based on the face that we haven't seen this before, it might be cause by a rare stochastic bug), and try to fix in another PR.
|
yes, seems like this crashing is very stochastic, I've tried to fix it with stronger atol, it was still failing, then I removed it and it passed the tests. Meanwhile locally everything worked fine all the time. |
5 tasks
swarnim-j
added a commit
to swarnim-j/gflownet
that referenced
this pull request
Nov 10, 2024
Update .gitignore and add logs directory Merge pull request alexhernandezgarcia#339 from alexhernandezgarcia/fix-pymagen-test Remove atol from test Fix failing batch test Refactor code to save figures in evaluator Update GFlowNetEnv class to call reset() before setting initial state and action space Update base.yaml and pruning.yaml with default settings for pruning experiment Add train_lenet.py script for training and evaluating LeNet model on CIFAR-10 dataset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the names of the spacegroups in
gflownet/envs/crystals/space_groups.yamlsuch that they correspond to the new conventions in pymatgen=2024.8.9. All tests pass, but I'm not 100% sure this change doesn't affect some other things in the crystal-gfn. @alexhernandezgarcia or @carriepl if you have a moment to double check that it's all good, that would be very nice 🙏