Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruff check, ruff format --check, and pytest Github actions #176

Merged
merged 17 commits into from
Jun 12, 2024
Merged

Add ruff check, ruff format --check, and pytest Github actions #176

merged 17 commits into from
Jun 12, 2024

Conversation

wiseodd
Copy link
Collaborator

@wiseodd wiseodd commented Apr 26, 2024

Closes #152

Self-explanatory!

@wiseodd wiseodd added the enhancement New feature or request label Apr 26, 2024
@wiseodd wiseodd added this to the 0.2 milestone Apr 26, 2024
@wiseodd wiseodd requested review from aleximmer and runame April 26, 2024 20:06
@wiseodd wiseodd self-assigned this Apr 26, 2024
@wiseodd wiseodd mentioned this pull request Apr 27, 2024
Closed
@wiseodd wiseodd mentioned this pull request Jun 4, 2024
Merged
@wiseodd
Copy link
Collaborator Author

wiseodd commented Jun 4, 2024

TODO for self: Add "Contributing" section in the README.

runame
runame reviewed Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! See my suggestion for the linter settings.

@wiseodd wiseodd mentioned this pull request Jun 11, 2024
Closed
@wiseodd wiseodd linked an issue Jun 12, 2024 that may be closed by this pull request
FeatureExtractor and Python <3.11 #195
Closed
@wiseodd wiseodd requested a review from runame June 12, 2024 19:28
runame
runame approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wiseodd wiseodd merged commit 7763a52 into main Jun 12, 2024
3 checks passed
@wiseodd wiseodd deleted the ruff-action branch June 12, 2024 20:18
@wiseodd wiseodd mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

@aleximmer aleximmer Awaiting requested review from aleximmer

Assignees

@wiseodd wiseodd

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2
Development

Successfully merging this pull request may close these issues.

FeatureExtractor and Python <3.11 Add linting and formatting via ruff
2 participants
@wiseodd @runame