-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expectation examples #263
Expectation examples #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my comments, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding the example. Some comment on a higher level but not necessary to add: it would be cool to plot the EI function and then compute the gradient at some point and add that to the plot as well to visualize the example mot intuitively.
Example of how to leverage the newly added
functional_samples
method #243.I also added the abstract interface for
samples
andfunctional_samples
toBaseLaplace
.