Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expectation examples #263

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Expectation examples #263

merged 5 commits into from
Feb 4, 2025

Conversation

wiseodd
Copy link
Collaborator

@wiseodd wiseodd commented Dec 4, 2024

Example of how to leverage the newly added functional_samples method #243.

I also added the abstract interface for samples and functional_samples to BaseLaplace.

@wiseodd wiseodd added the documentation Improvements or additions to documentation label Dec 4, 2024
@wiseodd wiseodd requested review from aleximmer and runame December 4, 2024 20:11
@wiseodd wiseodd self-assigned this Dec 4, 2024
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my comments, LGTM.

Copy link
Owner

@aleximmer aleximmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the example. Some comment on a higher level but not necessary to add: it would be cool to plot the EI function and then compute the gradient at some point and add that to the plot as well to visualize the example mot intuitively.

@wiseodd wiseodd merged commit 8aa9b16 into main Feb 4, 2025
4 checks passed
@wiseodd wiseodd deleted the expectation-examples branch February 4, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants