Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: increase error tolerance in PanamaFloatVectorOpsSpec #631

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

alexklibisz
Copy link
Owner

Related Issue

Maybe #617

Changes

Some tests have been failing recently with errors like:

image

https://github.com/alexklibisz/elastiknn/actions/runs/7152449485/job/19477803203?pr=630

The implementation seems fine. E.g., the RecallSuite continues to pass with no meaningful changes and the benchmarks, too. So I'm just bumping up the error tolerance here.

Testing and Validation

Standard CI

@alexklibisz alexklibisz merged commit 85f7f01 into main Dec 9, 2023
5 checks passed
@alexklibisz alexklibisz deleted the increase-error-tolerance branch December 9, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant