perf: Compute disallowed result once #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmg
force-pushed
the
cache-disallowed-result
branch
from
2249f1e to
4eb9bb4
Compare
alexmg
changed the title
|
The probability of Wozniak being boring, and the loop being entered a second time is low, but I might make this configurable in the future in case someone has a strong opinion about who else isn't boring. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disallowed result was computed on each iteration (causing a string allocation) of the
do-whileloop, which seems wasteful. This PR moves the computation of the disallowed result out of the loop.