Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for PositionSelectedCommand not working with custom Command #519

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for PositionSelectedCommand not working with custom Command #519

wants to merge 1 commit into from

Conversation

Dualitys
Copy link

Files Changed:

  1. MainViewModel in Demo.csproj
  2. CarouselViewControl in CarouselView.FormsPlugin.Abstractions

Fixed the bindable property to correctly accept and return custom ICommand implementations, to work with Prism for example.

@alexrainman
Copy link
Owner

Awesome. Will merge this change.

@alexrainman
Copy link
Owner

I cannot use this in my current implementation as ICommand doesn't support type argument.

@Dualitys
Copy link
Author

Could try fixing that if I knew where and how you need the typed argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dualitys @alexrainman