Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing IllegalArgumentException while using many fingers to zooming #579

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shnaz
Copy link

@shnaz shnaz commented Jul 9, 2020

This is a fix to a android framework bug, which occurs when zooming on an image inside a ViewPager. Related to this bug: #563 (comment)

Known bugs:
Baseflow/PhotoView#31
https://stackoverflow.com/questions/26315781/illegalargumentexception-pointerindex-out-of-range-when-i-pinchzoom-the-image

@shnaz
Copy link
Author

shnaz commented Jul 9, 2020

We have had thousands of these exceptions in our apps. It would be so cool if this was fixed.

@shnaz
Copy link
Author

shnaz commented Jul 21, 2020

@alexrainman Hi Alex, what do you think about this? best regards

@alexrainman
Copy link
Owner

@shnaz i am going to release a new version between today and tomorrow. Let's apply this fix to the new version instead.

@shnaz
Copy link
Author

shnaz commented Jan 4, 2021

@alexrainman It would be great if this fix could come out soon, we still have a lot of these exceptions which we cant really do anything about ourselves.

@shnaz
Copy link
Author

shnaz commented Mar 15, 2021

@alexrainman Hey man, sorry to bother you, but this keeps crashing our app and is actually the one with most occurences in our current app version.
Any chance this gets released soon?

Thanks in advance

Best regards

@dexxtr
Copy link

dexxtr commented Mar 31, 2021

I have absolutely the same bug as @shnaz has. Can we expect this fix in the next release, @alexrainman ? If yes, when it can happened? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants