fix(a11y): have unique ids for favorite/recent lists

[mxschmitt]

There are two distinct a11y bugs which are related to each-other:

1. The main input .DocSearch-Input contains aria-controls="docsearch-recentSearches-list docsearch-favoriteSearches-list" which is not compliant because the recentSearches or favoriteSearches elements do not exist all the time in the DOM. Only if existing favorites or recent searches they should be added - see Ensures all ARIA attributes have valid values (#docsearch-input): A11y_Playwright OSS releases_Saerch_AI4W microsoft/playwright.dev#1628. The fix for this is in fix(autocomplete): filter out empty collections in aria-controls autocomplete#1302.
2. When there is a Recent and a Favourite results list is shown, they share the same underlying id="docsearch-list". This PR addresses that and adds a test for both issues.

Investigation

This seems to render the search list here:

docsearch/packages/docsearch-react/src/StartScreen.tsx

Line 49 in aa666de

<Results

Which calls <ul {...props.getListProps()}> here:

docsearch/packages/docsearch-react/src/Results.tsx

Line 31 in 7f670b6

<ul {...props.getListProps()}>

Which gets its value from a different package:

https://github.com/algolia/autocomplete/blob/f05a701724d75fc3ade5e49c93d23077fb200371/packages/autocomplete-core/src/getPropGetters.ts#L302

And reads its value from here:

docsearch/packages/docsearch-react/src/DocSearchModal.tsx

Line 131 in db8edeb

id: 'docsearch',

So it looks like getListProps reads source only from the passed parameters. This PR passes the source over in the params.

Thanks for the review. Max.

[netlify]

👷 Deploy request for docsearch pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	948c219

[mxschmitt]

Status: Depends on a new version autocomplete - will rebase once algolia/autocomplete#1302 has been released.

[mxschmitt]

Should be ready for review @shortcuts.