Refactor build binaries workflow #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/build-binaries.yaml
* chore: notarise the folder * chore: codesign .framework * Sign Python
* chore: try entitlements * chore: staple * chore: test * chore: test
* fix: fix issue of goal command interacting with filename containing dot (algorandfoundation#424) * fix: fixed issue with filename containing dot * fix: make the regex simpler * 1.11.4 1.11.4 skip-checks: true * chore: binary distribution build refactor (algorandfoundation#428) * chore: refactor binary build to better support variations in platform specific builds * chore: update a dependency version * fix: upload windows artifact to release (algorandfoundation#429) * chore: build for mac * chore: fix * chore: fix * chore: fix * chore: fix * chore: fix * chore: fix artifact names --------- Co-authored-by: Negar <[email protected]> Co-authored-by: semantic-release <semantic-release> Co-authored-by: Neil Campbell <[email protected]>
# Conflicts: # .github/actions/build-binaries/action.yaml # .github/workflows/build-binaries.yaml
PatrickDinh
commented
Feb 26, 2024
| @@ -34,9 +35,85 @@ jobs: | |||
| - name: Install dependencies | |||
| run: poetry install --no-interaction | |||
|
|
|||
| - name: Build & test binary | |||
| uses: ./.github/actions/build-binaries | |||
| - name: Set release version | |||
There was a problem hiding this comment.
The rest of this file was copied from build-binaries/action.yaml.
neilcampbell
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #389