Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ACK_HIGH_PRIO option in the config file should set the value of SwitchNode::m_ackHighPrio #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ColdPorridge
Copy link

PR Description

The ACK_HIGH_PRIO option in the config file is intended to control whether ACK packets are placed in the high-priority queue of the NICs and switches in network.

In third.cc, the following code uses the ACK_HIGH_PRIO setting to decide whether ACK packets should be placed in the highest priority queue on the NIC.

// Set ACK priority on hosts
if (ack_high_prio)
    RdmaEgressQueue::ack_q_idx = 0;
else
    RdmaEgressQueue::ack_q_idx = 3;

However, in third.cc, there is no code that sets the value of SwitchNode::m_ackHighPrio. As a result, regardless of the ACK_HIGH_PRIO value in the config file, SwitchNode::m_ackHighPrio is always 0. This causes ACK packets to always share the same queue with other packets on the switch, regardless of the configuration.

This PR addresses the issue by ensuring that SwitchNode::m_ackHighPrio is correctly set based on the ACK_HIGH_PRIO option in the config file.

@CLAassistant
Copy link

CLAassistant commented Dec 28, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants