The ACK_HIGH_PRIO option in the config file should set the value of SwitchNode::m_ackHighPrio #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The
ACK_HIGH_PRIO
option in theconfig
file is intended to control whether ACK packets are placed in the high-priority queue of the NICs and switches in network.In
third.cc
, the following code uses theACK_HIGH_PRIO
setting to decide whether ACK packets should be placed in the highest priority queue on the NIC.However, in
third.cc
, there is no code that sets the value ofSwitchNode::m_ackHighPrio
. As a result, regardless of theACK_HIGH_PRIO
value in the config file,SwitchNode::m_ackHighPrio
is always0
. This causes ACK packets to always share the same queue with other packets on the switch, regardless of the configuration.This PR addresses the issue by ensuring that
SwitchNode::m_ackHighPrio
is correctly set based on theACK_HIGH_PRIO
option in the config file.