Skip to content

Commit

Permalink
chore: don't reinstall (may trigger upgrade) if libarrow-dev has alre…
Browse files Browse the repository at this point in the history
…ady been installed (#3241)

Otherwise other packages that requires (e.g., vineyard) will be broken
since we don't rebuild them after upgrading libarrow-dev.

Signed-off-by: Tao He <[email protected]>
  • Loading branch information
sighingnow authored Sep 20, 2023
1 parent 83d5a26 commit 6e883d2
Showing 1 changed file with 13 additions and 9 deletions.
22 changes: 13 additions & 9 deletions python/graphscope/gsctl/scripts/install_deps_command.sh
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,19 @@ ANALYTICAL_MACOS=(
)

_install_apache_arrow_ubuntu() {
log "Installing apache-arrow."
${SUDO} apt-get install -y lsb-release
# shellcheck disable=SC2046,SC2019,SC2018
wget -c https://apache.jfrog.io/artifactory/arrow/"$(lsb_release --id --short | tr 'A-Z' 'a-z')"/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb \
-P /tmp/
${SUDO} apt-get install -y -V /tmp/apache-arrow-apt-source-latest-"$(lsb_release --codename --short)".deb
${SUDO} apt-get update -y
${SUDO} apt-get install -y libarrow-dev
rm /tmp/apache-arrow-apt-source-latest-*.deb
if ! command -v dpkg -s libarrow-dev &>/dev/null; then
log "Installing apache-arrow."
${SUDO} apt-get install -y lsb-release
# shellcheck disable=SC2046,SC2019,SC2018
wget -c https://apache.jfrog.io/artifactory/arrow/"$(lsb_release --id --short | tr 'A-Z' 'a-z')"/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb \
-P /tmp/
${SUDO} apt-get install -y -V /tmp/apache-arrow-apt-source-latest-"$(lsb_release --codename --short)".deb
${SUDO} apt-get update -y
${SUDO} apt-get install -y libarrow-dev
rm /tmp/apache-arrow-apt-source-latest-*.deb
else
log "apache-arrow (libarrow-dev) already installed, skip."
fi
}

_install_java_maven_ubuntu() {
Expand Down

0 comments on commit 6e883d2

Please sign in to comment.