Fix inaccurate internal error code (#787)

alibaba · Sep 8, 2021 · b152c3e · b152c3e
1 parent dc8f214
commit b152c3e
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/coordinator/gscoordinator/coordinator.py b/coordinator/gscoordinator/coordinator.py
@@ -502,16 +502,20 @@ def RunStep(self, request, context):
             run_dag_on, dag_def = next_dag
             try:
                 if run_dag_on == GSEngine.analytical_engine:
+                    error_code = error_codes_pb2.ANALYTICAL_ENGINE_INTERNAL_ERROR
                     self.run_on_analytical_engine(
                         request.session_id, dag_def, op_results
                     )
                 elif run_dag_on == GSEngine.interactive_engine:
+                    error_code = error_codes_pb2.INTERACTIVE_ENGINE_INTERNAL_ERROR
                     self.run_on_interactive_engine(
                         request.session_id, dag_def, op_results
                     )
                 elif run_dag_on == GSEngine.learning_engine:
+                    error_code = error_codes_pb2.LEARNING_ENGINE_INTERNAL_ERROR
                     self.run_on_learning_engine(request.session_id, dag_def, op_results)
                 elif run_dag_on == GSEngine.coordinator:
+                    error_code = error_codes_pb2.COORDINATOR_INTERNAL_ERROR
                     self.run_on_coordinator(request.session_id, dag_def, op_results)
             except grpc.RpcError as exc:
                 # Not raised by graphscope, maybe socket closed, etc
@@ -520,8 +524,8 @@ def RunStep(self, request, context):
                 return message_pb2.RunStepResponse()
             except Exception as exc:
                 return self._make_response(
-                    error_codes_pb2.ANALYTICAL_ENGINE_INTERNAL_ERROR,
-                    "Error occurred during preprocessing: " + traceback.format_exc(),
+                    error_code,
+                    f"Error occurred during preprocessing, The traceback is: {traceback.format_exc()}",
                     pickle.dumps(exc),
                 )
         return message_pb2.RunStepResponse(results=op_results)