Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Fix bugs in Label Name to Id Conversion #3221

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Sep 14, 2023

What do these changes do?

When converting a label name into an ID, it is necessary to first infer whether it is a vertex label or an edge label based on the operator preceding the elementMap. There will be issues when the preceding operator falls into one of the following categories:

  1. When the preceding operator is an ExpandFusionStep after optimization (fusion of outE + filter + inV);
  2. When the preceding operator is an operator like limit or where that does not change the input type.

This PR addresses the two issues mentioned above.

Related issue number

fix #3219

Fixes

@codecov-commenter
Copy link

Codecov Report

Merging #3221 (e9c083e) into main (07104f4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3221   +/-   ##
=======================================
  Coverage   42.05%   42.05%           
=======================================
  Files         101      101           
  Lines       10985    10985           
=======================================
  Hits         4620     4620           
  Misses       6365     6365           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07104f4...e9c083e. Read the comment docs.

@longbinlai longbinlai merged commit 11d6ae6 into alibaba:main Sep 14, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] unexpected result returned by elementMap() in GIE
3 participants