Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interactive): support extract intervals from temporal types in GIE #3229

Merged
merged 24 commits into from
Oct 18, 2023

Conversation

BingqingLyu
Copy link
Collaborator

@BingqingLyu BingqingLyu commented Sep 18, 2023

What do these changes do?

As titled. Specifically,

Proto:

  1. refine definition of extract-expression
  2. define values of temporal types in results.proto

Compiler:

  1. construct extract-expression
  2. process returned values of temporal types

Pegasus Runtime:

  1. parsing extract-expression
  2. support extract intervals from temporal types
  3. encoding temporal types from storage (csr) to runtime
  4. return value of temporal types

HighQPS Runtime:

  1. parsing extract-expression
  2. return value of temporal types

Related issue number

Fixes #3228

@BingqingLyu BingqingLyu marked this pull request as draft September 18, 2023 08:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #3229 (d830d89) into main (2e9db66) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3229   +/-   ##
=======================================
  Coverage   42.06%   42.06%           
=======================================
  Files         101      101           
  Lines       11021    11021           
=======================================
  Hits         4636     4636           
  Misses       6385     6385           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6d46c...d830d89. Read the comment docs.

@BingqingLyu BingqingLyu marked this pull request as ready for review September 26, 2023 03:10
@BingqingLyu BingqingLyu removed the wip label Sep 26, 2023
zhanglei1949
zhanglei1949 previously approved these changes Sep 27, 2023
Committed-by: bingqing.lbq from Dev container
Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BingqingLyu BingqingLyu merged commit 7cb43e9 into alibaba:main Oct 18, 2023
46 of 47 checks passed
@BingqingLyu BingqingLyu deleted the ir_runtime_extract branch October 18, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support extract interval from temporal types in GIE
5 participants