Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Fix Implicit Type Conversion Issues in HQPS #3256

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Sep 22, 2023

What do these changes do?

Throw an error when the user input parameters are inconsistent with the procedure config, to prevent the wrong type causing engine errors.

Related issue number

Fixes

@codecov-commenter
Copy link

Codecov Report

Merging #3256 (b478663) into main (07104f4) will increase coverage by 0.01%.
Report is 12 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3256      +/-   ##
==========================================
+ Coverage   42.05%   42.06%   +0.01%     
==========================================
  Files         101      101              
  Lines       10985    10987       +2     
==========================================
+ Hits         4620     4622       +2     
  Misses       6365     6365              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e883d2...b478663. Read the comment docs.

@shirly121 shirly121 requested a review from BingqingLyu October 10, 2023 09:58
@shirly121 shirly121 merged commit d8b0185 into alibaba:main Oct 10, 2023
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants