Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Fix Bugs in Dynamic Params #3279

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Oct 10, 2023

What do these changes do?

Fix bugs in dynamic params:

  1. Fix bugs where multiple dynamic parameters with the same name appeared in a query.
  2. Fix bugs in dynamic parameter type inference when dynamic parameter is nested in a complex expression (i.e. $age + 1).

Related issue number

Fixes

@shirly121 shirly121 marked this pull request as ready for review October 10, 2023 11:18
@codecov-commenter
Copy link

Codecov Report

Merging #3279 (643bb10) into main (d065429) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3279   +/-   ##
=======================================
  Coverage   42.06%   42.06%           
=======================================
  Files         101      101           
  Lines       11021    11021           
=======================================
  Hits         4636     4636           
  Misses       6385     6385           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d065429...643bb10. Read the comment docs.

@longbinlai longbinlai merged commit ff8a795 into alibaba:main Oct 19, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants