fix(interactive): Support Index predicate for dynamic params in IR-Core #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longbinlai
reviewed
Oct 16, 2023
| @@ -191,10 +191,16 @@ message Limit { | |||
| // where the values referred by k1, k2, ... are indexed and hence the | |||
| // predicate can be efficiently verified by leveraging the index. | |||
| message IndexPredicate { | |||
| message PkValue { | |||
There was a problem hiding this comment.
Looks like PKValue is not quite necessary here, Simply define
message Triplet {
common.Property key = 1;
// The value can be either a constant value, or a parameter (in stored procedure)
one of value {
common.Value const = 2;
common.DynamicParam param = 3;
}
}
Committed-by: bingqing.lbq from Dev container
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3282 +/- ##
=======================================
Coverage 42.06% 42.06%
=======================================
Files 101 101
Lines 11021 11021
=======================================
Hits 4636 4636
Misses 6385 6385 Continue to review full report in Codecov by Sentry.
|
longbinlai
previously approved these changes
Oct 18, 2023
zhanglei1949
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As titled.
Related issue number
#3277