Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Distinguish 'label equals' or 'unique key equals' from Filter Conditions #3285

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Oct 12, 2023

What do these changes do?

  1. distinguish 'label equals' or 'unique key equals' from filter conditions, 'label equals' is fused to decide the label type while 'unique key equals' is fused for index predicate.
  2. convert index predicate from RelNode to ir core.
  3. handle special cases when converting 'SEARCH' operator from RelNode to ir core. Specifically, if 'SEARCH' happens in index predicate or the operand of 'SEARCH' is a continuous range, it will be converted to multiple conditions connected by 'and' or 'or'. These conversions may not necessarily be reasonable, at least in order to make ir core supported.

Related issue number

Fixes

@shirly121 shirly121 requested a review from longbinlai October 12, 2023 08:33
@shirly121 shirly121 marked this pull request as ready for review October 12, 2023 08:33
@shirly121 shirly121 changed the title fix(interactive): Distinguish 'label equals' or 'unique key equals' from filter conditions fix(interactive): Distinguish 'label equals' or 'unique key equals' from Filter Conditions Oct 12, 2023
longbinlai
longbinlai previously approved these changes Oct 19, 2023
Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #3285 (7f0005e) into main (f813f9b) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3285   +/-   ##
=======================================
  Coverage   42.06%   42.06%           
=======================================
  Files         101      101           
  Lines       11021    11021           
=======================================
  Hits         4636     4636           
  Misses       6385     6385           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f813f9b...7f0005e. Read the comment docs.

@longbinlai longbinlai merged commit 944a645 into alibaba:main Oct 19, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants