Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interactive): Fix Type Inference in 'ARRAY_VALUE_CONSTRUCTOR' and 'MAP_VALUE_CONSTRUCTOR' #3287

Merged
merged 20 commits into from
Nov 1, 2023

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Oct 12, 2023

What do these changes do?

Support ARRAY_VALUE_CONSTRUCTOR and MAP_VALUE_CONSTRUCTOR operators end-to-end, to support queries like:

Match (a:PERSON) Return [a.name, b.age];
Match (a:PERSON) Return {name: a.name, age: b.age};

Related issue number

Fixes

@shirly121 shirly121 requested a review from longbinlai October 12, 2023 08:54
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #3287 (2ccf1b1) into main (9de9055) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3287   +/-   ##
=======================================
  Coverage   41.04%   41.04%           
=======================================
  Files         109      109           
  Lines       11298    11298           
=======================================
  Hits         4637     4637           
  Misses       6661     6661           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de9055...2ccf1b1. Read the comment docs.

Committed-by: bingqing.lbq from Dev container
Committed-by: bingqing.lbq from Dev container
@BingqingLyu BingqingLyu marked this pull request as draft October 17, 2023 04:15
@shirly121 shirly121 marked this pull request as ready for review October 24, 2023 03:48
@shirly121 shirly121 requested a review from BingqingLyu October 24, 2023 03:48
@shirly121 shirly121 changed the title fix(interactive): Fix Type Inference in 'ARRAY_VALUE_CONSTRUCTOR' and 'MAP_VALUE_CONSTRUCTOR' feat(interactive): Fix Type Inference in 'ARRAY_VALUE_CONSTRUCTOR' and 'MAP_VALUE_CONSTRUCTOR' Oct 24, 2023
@longbinlai longbinlai merged commit e8501a8 into alibaba:main Nov 1, 2023
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants