feat(flex): Support using property of string type as primary key for vertex #3296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liulx20
force-pushed
the
string_support
branch
from
cec8469 to
94578b1
Compare
liulx20
changed the title
zhanglei1949
changed the title
| label_t src_label, dst_label, edge_label; | ||
| arc >> src_label; | ||
| arc.GetBytes(sizeof(oid_t)); | ||
| arc >> temp; | ||
| // arc.GetBytes(sizeof(PropertyType) + sizeof(int64_t)); |
There was a problem hiding this comment.
These comments can be removed?
| @@ -22,7 +22,7 @@ static uint32_t get_vertex_vid(const gs::ReadTransaction& txn, uint8_t label, | |||
| uint32_t vid = std::numeric_limits<uint32_t>::max(); | |||
| auto vit = txn.GetVertexIterator(label); | |||
| for (; vit.IsValid(); vit.Next()) { | |||
| if (vit.GetId() == id) { | |||
| if (vit.GetId().AsInt64() == id) { | |||
There was a problem hiding this comment.
If the result of vit.GetId() must be int64(), do the check first?
There was a problem hiding this comment.
Checked inside the AsXX() function
| @@ -22,7 +22,7 @@ static uint32_t get_vertex_vid(const gs::ReadTransaction& txn, uint8_t label, | |||
| uint32_t vid = std::numeric_limits<uint32_t>::max(); | |||
There was a problem hiding this comment.
using oid_t = int64_t; declared in flex/storages/rt_mutable_graph/types.h should be removed, and we shall ensure can remove all usage of oid_t is this PR?
liulx20
changed the title
luoxiaojian
previously approved these changes
Oct 20, 2023
…into string_support
luoxiaojian
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
oid support string_view
Related issue number
Fixes