fix(interactive): Support Index predicate with multiple expected values given via P.within() #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committed-by: bingqing.lbq from Dev container
Committed-by: bingqing.lbq from Dev container
BingqingLyu
changed the title
BingqingLyu
changed the title
longbinlai
reviewed
Oct 19, 2023
| }], | ||
| }; | ||
| return Ok(Some(idx_pred)); | ||
| if is_within && is_array_const(c) { |
There was a problem hiding this comment.
感觉 is_array_const 没必要有。直接进入里面match，还省得match这个 value两次？
Committed-by: bingqing.lbq from Dev container
siyuan0322
approved these changes
Oct 19, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3300 +/- ##
=======================================
Coverage 42.06% 42.06%
=======================================
Files 101 101
Lines 11021 11021
=======================================
Hits 4636 4636
Misses 6385 6385 Continue to review full report in Codecov by Sentry.
|
longbinlai
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As titled.
Related issue number
Fixes #3299