Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Fix Bugs in Converting Match into Join #3311

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

shirly121
Copy link
Collaborator

What do these changes do?

This PR fixes a bug related to queries like Match (a) Match (a)-[]->(b), (b)-[]->(c) Return a, b, where there are multiple sentences in the second Match clause, causing issues when converting such matches into join structures.

Related issue number

Fixes

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #3311 (d5df2bb) into main (a6fd8ba) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3311   +/-   ##
=======================================
  Coverage   41.39%   41.39%           
=======================================
  Files         107      107           
  Lines       11203    11203           
=======================================
  Hits         4637     4637           
  Misses       6566     6566           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c5f26...d5df2bb. Read the comment docs.

longbinlai
longbinlai previously approved these changes Oct 25, 2023
zhanglei1949
zhanglei1949 previously approved these changes Oct 25, 2023
@shirly121 shirly121 dismissed stale reviews from zhanglei1949 and longbinlai via d5df2bb October 25, 2023 09:59
@longbinlai longbinlai merged commit 1942a67 into alibaba:main Oct 26, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants