Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Decode the k8s node selector and convert it as a dict. #3477

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

dashanji
Copy link
Collaborator

What do these changes do?

As titled.

During test, I find not all pods are scheduled to the same node.

NAME                                             READY   STATUS    RESTARTS   AGE     IP            NODE           NOMINATED NODE   READINESS GATES
coordinator-ozgjbb-6c57549cf7-hhwqt              1/1     Running   0          4m2s    10.244.1.85   kind-worker    <none>           <none>
gs-engine-ozgjbb-0                               3/3     Running   0          3m58s   10.244.1.86   kind-worker    <none>           <none>
gs-engine-ozgjbb-1                               3/3     Running   0          114s    10.244.1.87   kind-worker    <none>           <none>
gs-engine-ozgjbb-2                               3/3     Running   0          108s    10.244.1.88   kind-worker    <none>           <none>
gs-engine-ozgjbb-ozgjbb-vineyard-etcd-0          1/1     Running   0          3m58s   10.244.3.71   kind-worker2   <none>           <none>
gs-interactive-frontend-ozgjbb-8d996bc8b-ctn6x   1/1     Running   0          3m58s   10.244.3.72   kind-worker2   <none>           <none>

We should support to add the node selector to the frontend and vineyard etcd.

Related issue number

Fixes #3476

siyuan0322
siyuan0322 previously approved these changes Jan 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 26.04%. Comparing base (00735b7) to head (5ff70c3).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3477       +/-   ##
===========================================
- Coverage   46.22%   26.04%   -20.18%     
===========================================
  Files         174      192       +18     
  Lines       16172    17340     +1168     
===========================================
- Hits         7476     4517     -2959     
- Misses       8696    12823     +4127     
Files Coverage Δ
...n/graphscope/deploy/kubernetes/resource_builder.py 71.48% <0.00%> (+46.28%) ⬆️

... and 82 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f5ad2...5ff70c3. Read the comment docs.

@dashanji dashanji changed the title fix(python): Decode the k8s node selector and convert it as a dict. [WIP] fix(python): Decode the k8s node selector and convert it as a dict. Feb 5, 2024
@dashanji dashanji changed the title [WIP] fix(python): Decode the k8s node selector and convert it as a dict. fix(python): Decode the k8s node selector and convert it as a dict. May 31, 2024
@dashanji dashanji force-pushed the fix-nodeselector-error branch from a3e19d6 to acaf439 Compare May 31, 2024 02:59
@yecol
Copy link
Collaborator

yecol commented Jun 7, 2024

Could you merge this PR? @dashanji

@dashanji
Copy link
Collaborator Author

Could you merge this PR? @dashanji

No problem.

@dashanji
Copy link
Collaborator Author

CI passed. /cc @siyuan0322

@siyuan0322 siyuan0322 merged commit dd8eb59 into alibaba:main Jun 11, 2024
20 checks passed
@dashanji dashanji deleted the fix-nodeselector-error branch June 11, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] session config k8s_coordinator_pod_node_selector Not effective
4 participants