Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): support non-blocking data loading interface in coordinator and fix failure during flexbuild process #3530

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

lidongze0629
Copy link
Collaborator

What do these changes do?

Related issue number

Fixes

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 308 lines in your changes are missing coverage. Please review.

Comparison is base (e9cffbd) 28.32% compared to head (6849fca) 27.89%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3530      +/-   ##
==========================================
- Coverage   28.32%   27.89%   -0.43%     
==========================================
  Files         173      176       +3     
  Lines       15923    16168     +245     
==========================================
  Hits         4510     4510              
- Misses      11413    11658     +245     
Files Coverage Δ
python/graphscope/flex/rest/api/legacy_api.py 0.00% <ø> (ø)
python/graphscope/gsctl/commands/common.py 0.00% <ø> (ø)
python/graphscope/gsctl/impl/legacy.py 0.00% <ø> (ø)
python/graphscope/flex/rest/api/__init__.py 0.00% <0.00%> (ø)
python/graphscope/flex/rest/models/__init__.py 0.00% <0.00%> (ø)
python/graphscope/flex/rest/__init__.py 0.00% <0.00%> (ø)
python/graphscope/gsctl/impl/__init__.py 0.00% <0.00%> (ø)
python/graphscope/gsctl/commands/dev.py 0.00% <0.00%> (ø)
python/graphscope/gsctl/impl/job.py 0.00% <0.00%> (ø)
python/graphscope/flex/rest/models/job_status.py 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9cffbd...6849fca. Read the comment docs.

@lidongze0629 lidongze0629 changed the title fix(interactive): support non-blocking data loading interface and fix failure during flexbuild process fix(interactive): support non-blocking data loading interface in coordinator and fix failure during flexbuild process Feb 2, 2024
zhanglei1949
zhanglei1949 previously approved these changes Feb 2, 2024
Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

acezen
acezen previously approved these changes Feb 2, 2024
@lidongze0629 lidongze0629 requested a review from liulx20 February 2, 2024 11:32
@lidongze0629 lidongze0629 merged commit d29516b into alibaba:main Feb 2, 2024
69 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants