Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): Bump up vineyard to v0.20.3 #3532

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

dashanji
Copy link
Collaborator

@dashanji dashanji commented Feb 4, 2024

What do these changes do?

The PR is to fix the bug caused by the version mismatch of vineyard in the graphscope-dev image.

As:
https://github.com/alibaba/GraphScope/actions/runs/7771225038/job/21192444777
https://github.com/alibaba/GraphScope/actions/runs/7753022954/job/21144025198

Also, the dev image updated.
https://github.com/alibaba/GraphScope/actions/runs/7773830300

@dashanji dashanji requested a review from siyuan0322 February 4, 2024 08:33
@dashanji dashanji force-pushed the fix-v6d-version-mismatch branch from f6480c9 to cd40df1 Compare February 4, 2024 09:10
Copy link
Collaborator

@siyuan0322 siyuan0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this... this vineyard version is fixed within each release

@dashanji dashanji force-pushed the fix-v6d-version-mismatch branch from cd40df1 to f628800 Compare February 4, 2024 13:47
@dashanji dashanji changed the title fix(k8s): Install the latest vineyard in the analytical.Dockerfile fix(k8s): Bump up vineyard to v0.20.3 Feb 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9228223) 48.81% compared to head (e4bcada) 24.33%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3532       +/-   ##
===========================================
- Coverage   48.81%   24.33%   -24.49%     
===========================================
  Files         177      176        -1     
  Lines       16198    16212       +14     
===========================================
- Hits         7907     3945     -3962     
- Misses       8291    12267     +3976     

see 74 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c8d15...e4bcada. Read the comment docs.

@dashanji dashanji force-pushed the fix-v6d-version-mismatch branch from 158c358 to 6e145d5 Compare February 5, 2024 05:03
@dashanji dashanji force-pushed the fix-v6d-version-mismatch branch from 6e145d5 to e4bcada Compare February 5, 2024 06:47
@dashanji
Copy link
Collaborator Author

dashanji commented Feb 5, 2024

@siyuan0322 Thanks for the advice, I update the dev image manually. Also, the k8s-test CI passed, could you please take another look at this?

@siyuan0322 siyuan0322 merged commit ebcf431 into alibaba:main Feb 5, 2024
44 checks passed
@dashanji dashanji deleted the fix-v6d-version-mismatch branch February 5, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants