refactor(interactive): Rename two temporal types, Date and Day to TimeStamp and Date #3726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Interactive support two temporal data types,
However, the naming of these two types doesn't really match its implementation. The struct
Date
actually stores a timestamp(in million second), the structDay
actually stores a Date(Year, Month and Day).set_day
andset_date
maybe used. Should be changed toset_date
andset_timestamp
.