Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(interactive): Rename two temporal types, Date and Day to TimeStamp and Date #3726

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Apr 18, 2024

Currently Interactive support two temporal data types,

  • Date
  • Day

However, the naming of these two types doesn't really match its implementation. The struct Date actually stores a timestamp(in million second), the struct Day actually stores a Date(Year, Month and Day).

  • This PR will also change the the data type usage in graph schema.
  • This PR may affect the previously written stored procedures, where set_day and set_date maybe used. Should be changed to set_date and set_timestamp.

@zhanglei1949 zhanglei1949 requested review from luoxiaojian and liulx20 and removed request for luoxiaojian April 18, 2024 11:27
@zhanglei1949 zhanglei1949 marked this pull request as draft April 23, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant