Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve the robustness of code #4170

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix: Improve the robustness of code #4170

merged 1 commit into from
Aug 23, 2024

Conversation

FLYLX
Copy link
Contributor

@FLYLX FLYLX commented Aug 21, 2024

What do these changes do?

Increase code robustness by making try-catch snippets of code that may cause resource leaks, and fixing some details.
Code optimization through the use of TONGYI LINGMA.

Related issue number

Fixes

README.md Outdated Show resolved Hide resolved
@@ -439,6 +439,11 @@ def get_graph_schema(
self,
graph_id: Annotated[StrictStr, Field(description="The id of graph to get")],
) -> Result[GetGraphSchemaResponse]:
#Get the schema of a specified graph.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FLYLX FLYLX force-pushed the tianchi branch 2 times, most recently from fbee9f2 to 83de613 Compare August 21, 2024 09:26
@lidongze0629 lidongze0629 requested a review from yecol August 22, 2024 02:21
@FLYLX FLYLX force-pushed the tianchi branch 2 times, most recently from 14f4920 to 7678707 Compare August 22, 2024 03:07
@lidongze0629 lidongze0629 changed the title [WIP]feat : Improve the robustness of code feat : Improve the robustness of code Aug 22, 2024
@lidongze0629 lidongze0629 changed the title feat : Improve the robustness of code fix : Improve the robustness of code Aug 22, 2024
@lidongze0629 lidongze0629 changed the title fix : Improve the robustness of code fix: Improve the robustness of code Aug 22, 2024
@FLYLX FLYLX force-pushed the tianchi branch 2 times, most recently from 063aec8 to 8c365aa Compare August 22, 2024 09:39
Copy link
Contributor

github-actions bot commented Aug 22, 2024

Please check the preview of the documentation changes at
https://991cb1a2.graphscope-docs-preview.pages.dev

Copy link
Collaborator

@lidongze0629 lidongze0629 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sighingnow sighingnow merged commit 482db71 into alibaba:main Aug 23, 2024
28 of 29 checks passed
liulx20 pushed a commit to liulx20/GraphScope that referenced this pull request Sep 4, 2024
Increase code robustness by making try-catch snippets of code that may
cause resource leaks, and fixing some details.
Code optimization through the use of TONGYI LINGMA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants