Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interactive): Introduce imdb as another example graph for Interactive #4208

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Sep 4, 2024

  • Add imdb graph as another example graph for Interactive.
  • Mark the supported and unsupported cypher queries(32/35).
  • Fix some problems of benchmark tools.
  • For graph.yaml with no type_id and property_id provided, we use incremental ids.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Please check the preview of the documentation changes at
https://8e0651ab.graphscope-docs-preview.pages.dev

@zhanglei1949 zhanglei1949 marked this pull request as draft September 4, 2024 08:37
Committed-by: xiaolei.zl from Dev container

Committed-by: xiaolei.zl from Dev container

modify

Committed-by: xiaolei.zl from Dev container

Committed-by: xiaolei.zl from Dev container
@zhanglei1949
Copy link
Collaborator Author

zhanglei1949 commented Sep 24, 2024

Currently the following query is supported by Interactive:

QueryName GIE Avg GIE P50 GIE P90 GIE P95 GIE P99 GIE Count
10a 14351.00 57 28645 28645 28645 2
12a 756.00 271 1241 1241 1241 2
13a 23417.00 23417 23417 23417 23417 1
14a 1330.50 618 2043 2043 2043 2
16a 448.00 448 448 448 448 1
17a 5305.00 5305 5305 5305 5305 1
18a 12815.00 12815 12815 12815 12815 1
19a 22198.00 22198 22198 22198 22198 1
1a 68.00 68 68 68 68 1
20a 236.33 305 328 328 328 3
22a 1358.33 1722 1787 1787 1787 3
23a 15697.00 15697 15697 15697 15697 1
24a 16161.00 16161 16161 16161 16161 1
25a 720.00 720 720 720 720 1
26a 253.00 253 253 253 253 1
28a 738.00 738 738 738 738 1
29a 8341.00 8341 8341 8341 8341 1
2a 73.00 73 73 73 73 1
30a 321.00 321 321 321 321 1
31a 1834.00 1834 1834 1834 1834 1
32a 47.00 23 71 71 71 2
32b 104.00 40 168 168 168 2
33a 161.00 161 161 161 161 1
3a 972.50 992 1033 1033 1033 4
4a 1561.67 1926 2016 2016 2016 3
5a 3291.00 3799 3930 3930 3930 3
5c 1626.00 1626 1626 1626 1626 1
6a 30.00 30 30 30 30 1
7a 998.00 998 998 998 998 1
8a 9154.00 9154 9154 9154 9154 1
9a 10784.00 10784 10784 10784 10784 1

Committed-by: xiaolei.zl from Dev container
@zhanglei1949 zhanglei1949 marked this pull request as ready for review September 24, 2024 09:54
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.33%. Comparing base (4eadc2e) to head (30e7013).
Report is 84 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4208       +/-   ##
===========================================
- Coverage   46.45%   34.33%   -12.13%     
===========================================
  Files         173      126       -47     
  Lines       16171    13235     -2936     
===========================================
- Hits         7512     4544     -2968     
- Misses       8659     8691       +32     

see 162 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abca708...30e7013. Read the comment docs.

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge for now, but Issue remains: #4260. Moreover, CBO has not yet been connected in Interactive, and, we may add a benchmark doc for showcasing Interactive's performance, while compared with other competitors.

@longbinlai longbinlai merged commit b814e5b into alibaba:main Sep 25, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants