Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade boost version to v1.75.0 for leaf #4211

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

lidongze0629
Copy link
Collaborator

@lidongze0629 lidongze0629 commented Sep 5, 2024

What do these changes do?

  • Upgrade boost version to at least v1.75.0 for using builtin leaf component
  • Upgrade v6d_version to v0.24.2 for building wheel packaging

@lidongze0629 lidongze0629 changed the title Upgrade boost version to v1.75.0 for leaf fix: upgrade boost version to v1.75.0 for leaf Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Please check the preview of the documentation changes at
https://88976b1e.graphscope-docs-preview.pages.dev

siyuan0322
siyuan0322 previously approved these changes Sep 5, 2024
zhanglei1949
zhanglei1949 previously approved these changes Sep 5, 2024
Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidongze0629 lidongze0629 dismissed stale reviews from zhanglei1949 and siyuan0322 via 394f85c September 6, 2024 03:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.48%. Comparing base (4eadc2e) to head (0e8ebb8).
Report is 50 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4211       +/-   ##
===========================================
- Coverage   46.45%   26.48%   -19.97%     
===========================================
  Files         173      203       +30     
  Lines       16171    18358     +2187     
===========================================
- Hits         7512     4862     -2650     
- Misses       8659    13496     +4837     

see 106 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd27de...0e8ebb8. Read the comment docs.

Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dashanji dashanji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidongze0629 lidongze0629 merged commit 445adf6 into alibaba:main Sep 6, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants