chore: fix log configuration format #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committed-by: siyuanzhang.zsy from Dev container
|
Please check the preview of the documentation changes at |
shirly121
added a commit
that referenced
this pull request
Sep 30, 2024
<!-- Thanks for your contribution! please review https://github.com/alibaba/GraphScope/blob/main/CONTRIBUTING.md before opening an issue. --> ## What do these changes do? Due to the PR #4255 , the Gremlin logs can not be printed properly. This PR fixes the issue using `Logback`. <!-- Please give a short brief about these changes. --> ## Related issue number <!-- Are there any issues opened that will be resolved by merging this change? --> Fixes
zhanglei1949
added a commit
that referenced
this pull request
Oct 11, 2024
…r and interactive SDK (#4284) The Interactive SDK and compiler both rely on gaia-ir-proto, including the protoc-generated classes. Previously, we used the maven-shade-plugin to shade the protoc files from the Interactive SDK, but this led to other build issues, as noted in PR #4255. In this PR, we address the problem by adding an additional jar classifier, `no-gaia-ir`, which can be easily utilized by the compiler.
shirly121
added a commit
to shirly121/GraphScope
that referenced
this pull request
Oct 12, 2024
<!-- Thanks for your contribution! please review https://github.com/alibaba/GraphScope/blob/main/CONTRIBUTING.md before opening an issue. --> ## What do these changes do? Due to the PR alibaba#4255 , the Gremlin logs can not be printed properly. This PR fixes the issue using `Logback`. <!-- Please give a short brief about these changes. --> ## Related issue number <!-- Are there any issues opened that will be resolved by merging this change? --> Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committed-by: siyuanzhang.zsy from Dev container