fix(interactive): Cut off the string if it exceeds max_length. #4359
+139
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committed-by: xiaolei.zl from Dev container
|
Please check the preview of the documentation changes at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4359 +/- ##
=======================================
Coverage 34.33% 34.33%
=======================================
Files 126 126
Lines 13257 13257
=======================================
Hits 4552 4552
Misses 8705 8705 Continue to review full report in Codecov by Sentry.
|
Committed-by: xiaolei.zl from Dev container
Committed-by: xiaolei.zl from Dev container
zhanglei1949
changed the title
zhanglei1949
changed the title
Committed-by: xiaolei.zl from Dev container
|
TODO: We should support VAR_CHAR on compiler first or all. @shirly121 |
Committed-by: xiaolei.zl from Dev container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.
Fix #4365
FIx #4383