Vulkan uses proper CMake Vulkan target #3079
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxt1234
reviewed
Nov 18, 2024
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.6) | |||
| cmake_minimum_required(VERSION 3.24) | |||
There was a problem hiding this comment.
It seems cmake version update too large.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current setup uses the raw path, which is problematic when building a project that uses MNN and offers a
Configfile, because the absolute path of Vulkan is embedded into MNN'sConfigfile. This makes use of the proper CMake target,Vulkan::Vulkan.I had to bump CMake's minimum version to 3.24 because the
GLOBALattribute required for this fix is only available from that version. Version 3.6 shouldn't be used anyway, as versions < 3.10 were deprecated in CMake 3.31.