Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useClickAway): callback shouldn't be invoked when a dynamic element inside target is clicked #2530

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(useClickAway): callback shouldn't be invoked when a dynamic element inside target is clicked #2530

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3fb08d
fix(useClickAway): callback shouldn't called when clicked on dynamic …
liuyib Apr 24, 2024
ab95053
Merge branch 'master' into fix_useClickAway_dynamic_dom
liuyib May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/hooks/src/useClickAway/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ export default function useClickAway<T extends Event = Event>(

useEffectWithTarget(
() => {
const handler = (event: any) => {
const handler = (event: T) => {
const targets = Array.isArray(target) ? target : [target];
if (
targets.some((item) => {
const targetElement = getTargetElement(item);
return !targetElement || targetElement.contains(event.target);
return !targetElement || event.composedPath().includes(targetElement);
})
) {
return;
Expand Down
Loading