Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add first-full-screen-paint in FirstChunkCache #7035

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions .github/workflows/canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,33 +6,47 @@ on:
- release/**

jobs:
check_changeset:
name: Check Changeset exists
outputs:
status: ${{ steps.check.outcome }}
runs-on: ubuntu-latest

steps:
- name: Checkout Branch
uses: actions/checkout@v4

- name: Check
id: check
continue-on-error: true
run: test "$(ls -1 .changeset | wc -l)" -gt "2"

canary:
name: Canary
name: Publish Canary
runs-on: ubuntu-latest
needs: check_changeset
if: needs.check_changeset.outputs.status == 'success'

strategy:
matrix:
node-version: [18]

steps:
- name: Checkout Branch
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install pnpm
uses: pnpm/action-setup@v4

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'pnpm'

- name: Setup
run: pnpm run setup

- name: Check changeset exists
run: test "$(ls -1 .changeset | wc -l)" -gt "2"

- name: Config npm
run: echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > .npmrc
env:
Expand Down
15 changes: 14 additions & 1 deletion packages/runtime/src/Document.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,20 @@ export const Data: DataType = (props: DataProps) => {
export type FirstChunkCacheType = () => JSX.Element;

export const FirstChunkCache: FirstChunkCacheType = () => {
return <div dangerouslySetInnerHTML={{ __html: '<!--fcc-->' }} />;
return (
<>
<script
dangerouslySetInnerHTML={{
__html: 'window.dispatchEvent(new Event("first-full-screen-paint"));',
}}
/>
<div
dangerouslySetInnerHTML={{
__html: '<!--fcc-->',
}}
/>
</>
);
};

export type MainType = (props: React.HTMLAttributes<HTMLDivElement>) => JSX.Element;
Expand Down
Loading