opt: rm some windows TODO mark

alibaba · Feb 25, 2025 · b63ae4e · b63ae4e
1 parent 794911f
commit b63ae4e
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 12 deletions.
diff --git a/core/CMakeLists.txt b/core/CMakeLists.txt
@@ -86,9 +86,9 @@ elseif (MSVC)
     add_definitions(-DWIN32_LEAN_AND_MEAN)
     set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /MT /MP /Zi")
     # /DEBUG will generate many pdb not found warning.
-    set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "${CMAKE_SHARED_LINKER_FLAGS_RELEASE} /OPT:REF /OPT:ICF")
-    set(CMAKE_STATIC_LINKER_FLAGS_RELEASE "${CMAKE_STATIC_LINKER_FLAGS_RELEASE} /OPT:REF /OPT:ICF")
-    set(CMAKE_EXE_LINKER_FLAGS_RELEASE "${CMAKE_EXE_LINKER_FLAGS_RELEASE} /OPT:REF /OPT:ICF")
+    set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "${CMAKE_SHARED_LINKER_FLAGS_RELEASE} /DEBUG /OPT:REF /OPT:ICF")
+    set(CMAKE_STATIC_LINKER_FLAGS_RELEASE "${CMAKE_STATIC_LINKER_FLAGS_RELEASE} /DEBUG /OPT:REF /OPT:ICF")
+    set(CMAKE_EXE_LINKER_FLAGS_RELEASE "${CMAKE_EXE_LINKER_FLAGS_RELEASE} /DEBUG /OPT:REF /OPT:ICF")
     set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} /MTd /MP")
     add_compile_options("/std:c++17")
     # for cross-platform, soure file all are utf8

diff --git a/core/plugin/processor/inner/ProcessorParseContainerLogNative.cpp b/core/plugin/processor/inner/ProcessorParseContainerLogNative.cpp
@@ -291,8 +291,7 @@ static int32_t parseLogType(char* buffer, int32_t idx, int32_t size, DockerLogTy
     return idx;
 }
 
-// TODO: windows
-// windows can't instantiation with char32_t, unsigend maybe not ok.
+// windows can't instantiation with char32_t.
 #if defined(_MSC_VER)
 std::wstring_convert<std::codecvt_utf8<unsigned long>, unsigned long> convert;
 #else

diff --git a/core/unittest/checkpoint/AdhocCheckpointManagerUnittest.cpp b/core/unittest/checkpoint/AdhocCheckpointManagerUnittest.cpp
@@ -242,8 +242,6 @@ AdhocFileKey* AdhocCheckpointManagerUnittest::GetAdhocFileKey(const std::string&
 long AdhocCheckpointManagerUnittest::GetFileUpdateTime(const std::string& filePath) {
     struct stat statbuf;
     stat(filePath.c_str(), &statbuf);
-    // TODO: windows
-    // it's ok?
 #if defined(__linux__)
     return statbuf.st_mtim.tv_nsec;
 #else

diff --git a/core/unittest/models/LogEventUnittest.cpp b/core/unittest/models/LogEventUnittest.cpp
@@ -165,7 +165,6 @@ void LogEventUnittest::TestMeta() {
 }
 
 void LogEventUnittest::TestSize() {
-    // TODO: windows
     size_t basicSize = sizeof(time_t) + sizeof(uint64_t) + sizeof(vector<pair<LogContent, bool>>);
     // add content, and key not existed
     mLogEvent->SetContent(string("key1"), string("a"));

diff --git a/core/unittest/models/MetricEventUnittest.cpp b/core/unittest/models/MetricEventUnittest.cpp
@@ -150,7 +150,6 @@ void MetricEventUnittest::TestTag() {
 }
 
 void MetricEventUnittest::TestUntypedSingleValueSize() {
-    // TODO: windows
     size_t basicSize
         = sizeof(time_t) + sizeof(uint64_t) + sizeof(UntypedSingleValue) + sizeof(map<StringView, StringView>);
     mMetricEvent->SetName("test");
@@ -174,7 +173,6 @@ void MetricEventUnittest::TestUntypedSingleValueSize() {
 void MetricEventUnittest::TestUntypedMultiDoubleValuesSize() {
     mMetricEvent->SetName("test");
     mMetricEvent->SetValue(map<StringView, UntypedMultiDoubleValue>{});
-    // TODO: windows
     size_t basicSize
         = sizeof(time_t) + sizeof(uint64_t) + sizeof(UntypedMultiDoubleValues) + sizeof(map<StringView, StringView>);
     basicSize += 4;
@@ -245,7 +243,6 @@ void MetricEventUnittest::TestUntypedSingleValueToJson() {
     string errorMsg;
     ParseJsonTable(eventStr, eventJson, errorMsg);
 
-    // TODO: windows
     APSARA_TEST_TRUE(eventJson.toStyledString() == res.toStyledString());
 }
 
@@ -284,7 +281,6 @@ void MetricEventUnittest::TestUntypedMultiDoubleValuesToJson() {
     string errorMsg;
     ParseJsonTable(eventStr, eventJson, errorMsg);
 
-    // TODO: windows
     APSARA_TEST_TRUE(eventJson.toStyledString() == res.toStyledString());
 }
 

diff --git a/core/unittest/reader/LogFileReaderUnittest.cpp b/core/unittest/reader/LogFileReaderUnittest.cpp
@@ -255,6 +255,8 @@ void LogFileReaderUnittest::TestReadGBK() {
         APSARA_TEST_FALSE_FATAL(moreData);
         expectedPart = expectedContent.get();
         expectedPart = expectedPart.substr(expectedPart.rfind("iLogtail"));
+        LOG_ERROR(sLogger, ("xxxxxxxxxxx", expectedPart.size()));
+        LOG_ERROR(sLogger, ("xxxxxxxxxxx", logBuffer.rawBuffer.size()));
         APSARA_TEST_STREQ_FATAL(expectedPart.c_str(), logBuffer.rawBuffer.data());
         APSARA_TEST_EQUAL_FATAL(0UL, reader.mCache.size());
     }