-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 大纲树选择节点的时候,支持默认展示其他属性tab #2516
Conversation
zude.hzd seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
感谢你的 PR,根据引擎的 研发协作流程,请将目标合入分支设置为 develop。 Thanks in advance, according to the Contribution Guideline, please set the base branch to develop. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2516 +/- ##
=======================================
Coverage 85.21% 85.21%
=======================================
Files 222 222
Lines 8947 8947
Branches 2099 2099
=======================================
Hits 7624 7624
Misses 1234 1234
Partials 89 89
☔ View full report in Codecov by Sentry. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 33.63% | 114/339 |
🔴 | Branches | 14.88% | 25/168 |
🔴 | Functions | 26.14% | 23/88 |
🔴 | Lines | 34.23% | 114/333 |
Test suite run success
2 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 5170c10
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟡 | Statements | 72.03% | 909/1262 |
🟡 | Branches | 61.19% | 566/925 |
🟡 | Functions | 69.12% | 197/285 |
🟡 | Lines | 72.02% | 893/1240 |
Test suite run success
96 tests passing in 8 suites.
Report generated by 🧪jest coverage report action from 5170c10
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 48.8% | 122/250 |
🔴 | Branches | 43.49% | 117/269 |
🔴 | Functions | 41.77% | 33/79 |
🔴 | Lines | 49.79% | 117/235 |
Test suite run success
33 tests passing in 6 suites.
Report generated by 🧪jest coverage report action from 5170c10
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 96.32% | 2854/2963 |
🟢 | Branches | 88.77% | 1628/1834 |
🟢 | Functions | 95.99% | 862/898 |
🟢 | Lines | 96.39% | 2779/2883 |
Test suite run success
370 tests passing in 42 suites.
Report generated by 🧪jest coverage report action from 5170c10
if (!engineConfig.get('stayOnTheSameSettingTab', false)) { | ||
this._activeKey = null; | ||
} | ||
// 选中指定tab | ||
if (tab) { | ||
this._activeKey = tab; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
回调里面可能有两次赋值,不能放到 else 里面吗
@@ -26,7 +26,7 @@ export class Selection implements ISelection { | |||
/** | |||
* 选中 | |||
*/ | |||
select(id: string) { | |||
select(id: string, tab?: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不应该修改这个方法
方便查看绑定属性,不用来回切换