feat: 新增选中节点指定属性tab功能 #2542
Closed
feat: 新增选中节点指定属性tab功能 #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zude.hzd seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 33.63% | 114/339 |
| 🔴 | Branches | 14.53% | 25/172 |
| 🔴 | Functions | 26.14% | 23/88 |
| 🔴 | Lines | 34.23% | 114/333 |
Test suite run success
2 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from ee446bc
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 48.8% | 122/250 |
| 🔴 | Branches | 43.49% | 117/269 |
| 🔴 | Functions | 41.77% | 33/79 |
| 🔴 | Lines | 49.79% | 117/235 |
Test suite run success
33 tests passing in 6 suites.
Report generated by 🧪jest coverage report action from ee446bc
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 96.23% (-0.09% 🔻) |
2857/2969 |
| 🟢 | Branches | 88.77% | 1628/1834 |
| 🟢 | Functions | 95.68% (-0.31% 🔻) |
863/902 |
| 🟢 | Lines | 96.3% (-0.1% 🔻) |
2782/2889 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / selection.ts |
92.11% (-2.34% 🔻) |
87.8% | 88.89% (-11.11% 🔻) |
92.11% (-2.34% 🔻) |
| 🟢 | ... / designer.ts |
93.42% (-0.36% 🔻) |
80.67% | 94.44% (-1.78% 🔻) |
93.25% (-0.37% 🔻) |
Test suite run success
370 tests passing in 42 suites.
Report generated by 🧪jest coverage report action from ee446bc
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 71.91% | 909/1264 |
| 🟡 | Branches | 61.16% | 570/932 |
| 🟡 | Functions | 68.88% | 197/286 |
| 🟡 | Lines | 71.96% | 893/1241 |
Test suite run success
96 tests passing in 8 suites.
Report generated by 🧪jest coverage report action from ee446bc
liujuping
reviewed
Oct 12, 2023
| @@ -106,6 +107,13 @@ export default class TreeTitle extends PureComponent<{ | |||
| const { node } = treeNode; | |||
| treeNode.deleteNode(node); | |||
| }; | |||
|
|
|||
| treeTitleClick = (e: any, type: string) => { | |||
| const { treeNodeClick } = this.props; | |||
There was a problem hiding this comment.
treeNodeClick 可以放到 treeNode 里面，不用多个组件进行透传。
| * select tab of props with tabKey | ||
| * @param tabKey | ||
| */ | ||
| selectPropsTab(tabKey: string): void { |
There was a problem hiding this comment.
docs/docs/api/model/selection.md
需要在这里补充一下 API 文档
|
PR 暂时关掉了，有需要重新打开 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增选中节点指定属性tab函数,大纲树节点点击特殊图表可以直接指向特定tab，方便快速观察绑定数据
