Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix problems caused by hoc priority #2598

Closed
wants to merge 1 commit into from

Conversation

liujuping
Copy link
Collaborator

@liujuping liujuping commented Oct 30, 2023

fixed #2596

@liujuping liujuping requested a review from JackLian as a code owner October 30, 2023 08:56
@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Coverage report for packages/react-simulator-renderer

❌ An unexpected error occurred. For more details, check console

Error: The process '/opt/hostedtoolcache/node/14.21.3/x64/bin/npm' failed with exit code 1
St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.53% 25/172
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run failed

Failed tests: 1/2. Failed suites: 1/1.
  ● Base › should be render Text

    expect(received).toMatchSnapshot()

    Snapshot name: `Base should be render Text 1`

    - Snapshot  - 1
    + Received  + 0

    @@ -9,11 +9,10 @@
            __designMode="design"
            __style__={Object {}}
            behavior="NORMAL"
            componentId="node_ockvuu8u916"
            fieldId="text_kvuu9gl2"
    -       forwardRef={[Function]}
            maxLine={0}
            showTitle={false}
          >
            我是一个简单的测试页面
          </div>

      27 |
      28 |     let tree = component.toJSON();
    > 29 |     expect(tree).toMatchSnapshot();
         |                  ^
      30 |   });
      31 | })

      at Object.<anonymous> (test/src/renderer/demo.test.tsx:29:18)

Report generated by 🧪jest coverage report action from bf016b7

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 49% 123/251
🔴 Branches 43.38% 118/272
🔴 Functions 42.5% 34/80
🔴 Lines 50% 118/236

Test suite run success

33 tests passing in 6 suites.

Report generated by 🧪jest coverage report action from bf016b7

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.1% 2855/2971
🟢 Branches 88.63% 1629/1838
🟢 Functions 95.67% 862/901
🟢 Lines 96.16% 2780/2891

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from bf016b7

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Coverage report for packages/renderer-core

❌ An unexpected error occurred. For more details, check console

Error: The process '/opt/hostedtoolcache/node/14.21.3/x64/bin/npm' failed with exit code 1
St.
Category Percentage Covered / Total
🟡 Statements
71.76% (+0.03% 🔼)
907/1264
🟡 Branches
60.69% (-0.06% 🔻)
565/931
🟡 Functions 68.18% 195/286
🟡 Lines
71.74% (-0.02% 🔻)
891/1242
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡 renderer/base.tsx
66.95% (+0.07% 🔼)
54.62% (-0.22% 🔻)
64.29%
66.88% (-0.07% 🔻)

Test suite run failed

Failed tests: 2/96. Failed suites: 1/8.
  ● lifecycle › props change and make componentWillReceiveProps

    expect(received).toMatchSnapshot()

    Snapshot name: `lifecycle props change and make componentWillReceiveProps 3`

    - Snapshot  - 1
    + Received  + 0

      <div>
        <div
    -     __tag="111"
          content="content 123"
        >
          content 123
        </div>
      </div>

      14 | const makeSnapshot = (component) => {
      15 |   let tree = component.toJSON();
    > 16 |   expect(tree).toMatchSnapshot();
         |                ^
      17 | }
      18 |
      19 | const baseRenderer: any = {

      at makeSnapshot (tests/hoc/leaf.test.tsx:16:16)
      at Object.<anonymous> (tests/hoc/leaf.test.tsx:191:5)

  ● lifecycle › leaf change and make componentWillReceiveProps

    expect(received).toMatchSnapshot()

    Snapshot name: `lifecycle leaf change and make componentWillReceiveProps 1`

    - Snapshot  - 1
    + Received  + 0

    @@ -1,9 +1,8 @@
      <div>
        <div
          __id="text6"
    -     __tag="222"
          componentId="text6"
          content="content new leaf"
        >
          content new leaf
        </div>

      14 | const makeSnapshot = (component) => {
      15 |   let tree = component.toJSON();
    > 16 |   expect(tree).toMatchSnapshot();
         |                ^
      17 | }
      18 |
      19 | const baseRenderer: any = {

      at makeSnapshot (tests/hoc/leaf.test.tsx:16:16)
      at Object.<anonymous> (tests/hoc/leaf.test.tsx:208:5)

Report generated by 🧪jest coverage report action from bf016b7

@liujuping liujuping closed this Oct 31, 2023
@liujuping liujuping reopened this Oct 31, 2023
@liujuping liujuping force-pushed the fix/compWrapper-first branch from bd19ed3 to bf016b7 Compare October 31, 2023 02:23
@liujuping liujuping closed this Nov 1, 2023
@JackLian JackLian deleted the fix/compWrapper-first branch January 2, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant