Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import schema 之后 cache 判断错误(#2596) #2601

Merged
merged 1 commit into from
Nov 1, 2023
Merged

fix: import schema 之后 cache 判断错误(#2596) #2601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/renderer-core/src/hoc/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function patchDidCatch(Comp: any, { baseRenderer }: Options) {
}
}

const cache = new Map();
const cache = new Map<string, { Comp: any; WrapperComponent: any }>();

export function compWrapper(Comp: any, options: Options) {
const { createElement, Component, forwardRef } = adapter.getRuntime();
Expand All @@ -62,8 +62,8 @@ export function compWrapper(Comp: any, options: Options) {
return Comp;
}

if (cache.has(options.schema.id)) {
return cache.get(options.schema.id);
if (cache.has(options.schema.id) && cache.get(options.schema.id)?.Comp === Comp) {
return cache.get(options.schema.id)?.WrapperComponent;
}

class Wrapper extends Component {
Expand All @@ -82,7 +82,7 @@ export function compWrapper(Comp: any, options: Options) {
Comp,
);

cache.set(options.schema.id, WrapperComponent);
cache.set(options.schema.id, { WrapperComponent, Comp });

return WrapperComponent;
}
Loading