Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve code and simplify logic #2651

Merged
merged 7 commits into from
Nov 23, 2023
Merged

fix: Improve code and simplify logic #2651

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
50137b9
fix: Improve code and simplify logic
andylili21 Nov 14, 2023
299af37
#补充单元测试
andylili21 Nov 20, 2023
34059c6
#格式化
andylili21 Nov 20, 2023
a5acc3b
#Unit Testing
andylili21 Nov 20, 2023
3bfedfb
#Adding UTs
andylili21 Nov 21, 2023
c727b41
#changeing explain
andylili21 Nov 22, 2023
2b94f21
#change case
andylili21 Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/designer/src/document/node/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,23 +440,23 @@ export class Node<Schema extends IPublicTypeNodeSchema = IPublicTypeNodeSchema>
}

private initialChildren(children: IPublicTypeNodeData | IPublicTypeNodeData[] | undefined): IPublicTypeNodeData[] {
// FIXME! this is dirty code
const { initialChildren } = this.componentMeta.advanced;

if (children == null) {
const { initialChildren } = this.componentMeta.advanced;
if (initialChildren) {
if (typeof initialChildren === 'function') {
return initialChildren(this.internalToShellNode()!) || [];
}
return initialChildren;
}
return [];
}

if (Array.isArray(children)) {
return children;
} else if (children) {
return [children];
} else {
return [];
}

return [children];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

children 为 undefined 的情况和原来输出是否一样。重构建议先补充相关的单元测试用例。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

想问一下补充相关的单元测试用例，可以在node.test.ts文件中添加测试用例，来测试函数在重构前后输出结果是否一样吗？

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以的。

}

isContainer(): boolean {
Expand Down Expand Up @@ -1094,7 +1094,7 @@ export class Node<Schema extends IPublicTypeNodeSchema = IPublicTypeNodeSchema>
}

/**
* 是否可执行某action
* 是否可执行某 action
*/
canPerformAction(actionName: string): boolean {
const availableActions =
Expand Down