Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12773] Fix unfriendly message when adding duplicate permissions. #12891

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

DirtyBit64
Copy link

What is the purpose of the change

Resolve the same issues in role management and permission management in the console : #12773.

Brief changelog

Modified com.alibaba.nacos.plugin.auth.impl.roles.NacosRoleServiceImpl.addXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


DirtyBit seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

DirtyBit added 3 commits November 24, 2024 21:54
# Conflicts:
#	plugin-default-impl/nacos-default-auth-plugin/src/main/java/com/alibaba/nacos/plugin/auth/impl/roles/NacosRoleServiceImpl.java
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 72.23%. Comparing base (2a0dafa) to head (446cb09).

Files with missing lines Patch % Lines
...s/plugin/auth/impl/roles/NacosRoleServiceImpl.java 0.00% 19 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12891      +/-   ##
=============================================
- Coverage      72.25%   72.23%   -0.03%     
+ Complexity      9826     9825       -1     
=============================================
  Files           1287     1287              
  Lines          41445    41464      +19     
  Branches        4373     4383      +10     
=============================================
+ Hits           29947    29951       +4     
- Misses          9396     9410      +14     
- Partials        2102     2103       +1     
Files with missing lines Coverage Δ
...s/plugin/auth/impl/roles/NacosRoleServiceImpl.java 24.20% <0.00%> (-3.34%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a0dafa...446cb09. Read the comment docs.

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants