-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #13138] fix processServiceInfo bug #13137
[ISSUE #13138] fix processServiceInfo bug #13137
Conversation
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
fix:#13137 |
@luky116 哈喽,提交代码需要先签一下CIA |
另外CI没过, 也需要fix一下 |
3b107c4
to
1262ee7
Compare
ok, i have signed CLA |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13137 +/- ##
=============================================
- Coverage 72.27% 72.17% -0.10%
+ Complexity 10034 10014 -20
=============================================
Files 1310 1310
Lines 42016 42028 +12
Branches 4416 4417 +1
=============================================
- Hits 30366 30333 -33
- Misses 9556 9609 +53
+ Partials 2094 2086 -8
... and 39 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
修复了,辛苦再看下 |
|
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
当前 nacos client 会接收一个 service 所有 cluster 的推送,然后在本地根据 clusters 选择 listerner 进行回调。所以,serviceInfoHolder 中的 map,直接存储 groupName@@serviceName 作为 key 就行了,不需要加上 clusters。
另外,代码中从 serviceInfoHolder 获取 value 的时候,也没有传 clusters,所以存的时候不能加 clusters 存储,可能导致问题

The current nacos client will receive pushes from all clusters in a service, and then select listener locally according to clusters to perform callbacks. Therefore, just store groupName@@serviceName as key in serviceInfoHolder, and you don't need to add clusters.
$$ In addition, when the value is obtained from serviceInfoHolder in the code, clusters are not passed, so clusters cannot be added when saving, which may cause problems.
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.