fix multiple issues with non-window scrolling context #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following issues when scrolling with a context besides the window:
scrollTop
el.getBoundingClientRect().top - context.getBoundingClientRect().top + context.scrollTop
)context.scrollHeight - context.offsetHeight
Note that this still doesn't work if there are nested scrolling elements between the context and the target element.
Also, this includes my other PR by accident. Let me know if you want to remove that PR from this.