Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign_up_window #4

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

sign_up_window #4

wants to merge 10 commits into from

Conversation

p0u74
Copy link
Collaborator

@p0u74 p0u74 commented Apr 16, 2023

Changes applied :

  • Class name changed to SignUpWindow
  • constants.py created
  • Window icon location added as constant
  • Imported constants

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete useless comments (all of yours are useless)
rewrite this in the DRY principle way
I told you to read and write this module based on MVC did you

Type of Comments Good Bad Example
Autogenerated Comments None Redundant N/A
Clarification Comments Rarely Often // Increment the counter.
Commented-Out Code None Creates Dead Code // someFunction();
Marker Comments Sometimes Unclear Intent // BEGIN MAIN PROGRAM
TODO Comments Rarely Often Left Unresolved // TODO: Refactor this function
Amplification Comments Sometimes Non-essential Information // This function calculates the sum of two numbers.
Javadocs, XmlDocs, etc. Sometimes Errors, Incorrect Information /** This method returns the name of the person. **/
Commented-Out Tests None Creates False Sense of Security N/A
Legal Comments Sometimes Unmaintained, Misleading // Copyright (c) 2021 Company Name
Explanation of Intent Sometimes Misleading, Duplication // Check if the input is valid.
Explanation of Implementation Seldom Error-Prone // Use quicksort algorithm to sort the array.
Warning of Consequences Sometimes Conflicts with Code // Be careful while modifying this code.
TODO Comments (Implementation) Seldom Code Should be Well-Designed // TODO: Implement this function using a better algorithm.
Debugging Comments Seldom Debuggers are More Effective // Print debug information.
Global Information Seldom Obvious, Distracting // This is the main function.

if you had any more question --> google

window_layout.addWidget(search_bar)

search_btn = QPushButton("Search", self)
window_layout.addWidget(search_btn)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you've learned about DRY right?
I totally remember to mention this line and line 23 does the same thing!!!!!!!!!!!!!!!

input_box = QLineEdit(self)
input_box.setGeometry(150, 400, 200, 30)
window_layout.addWidget(input_box)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as in here .... DRY please

@@ -0,0 +1 @@
WINDOW_ICON = "icon/app_icon.ico"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf is this?

@@ -0,0 +1,12 @@
import sys

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and wtf is this??????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants