-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump FairLogger to v2.1.0 and InfoLogger to v2.8.2 #5763
base: master
Are you sure you want to change the base?
Conversation
It looks like there is a genuine incompatibility between InfoLogger and the new FairLogger. |
ok, I will check if it is only these two |
Keep also in mind that c_str() is guaranteed to be 0 terminated, string_view is not. |
waiting for AliceO2Group/InfoLogger#95 to also bump InfoLogger here |
My bad, I messed up with the include file during the test... Will fix shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed infologger and pushed v2.8.2
The include issue escaped my attention as I did the release integration tests using InfoLogger instead of libInfoLogger (which is the one included by the O2 components).
the compiler on macOS throws a warning when using enums in switch statements (in this case The O2 PR to fix this is already open but needs the bump of FairLogger first: AliceO2Group/AliceO2#13957 |
Introducing a "critical" log message severity, required to distinguish critical errors for shifter operation.