[RW-13914][RW-13916][risk=no] Handle vwb egress alert (1st part) #8990
Conversation
yonghaoy
changed the title
api/db/changelog/db.changelog-246-add-vwb-egress-event-columns.xml
Outdated
Show resolved
Hide resolved
| "An egress event happened for workspace: %s, but we're unable to find a user %s.", | ||
| egressEvent.getVwbWorkspaceId(), egressEvent.getUserEmail())); | ||
| } | ||
| this.egressEventAuditor.fireVwbEgressEvent(egressEvent, egressUser.get()); |
There was a problem hiding this comment.
line 111 implies that egressUser can be empty, line 117 makes a call to egressUser.get which might be empty.
There was a problem hiding this comment.
this whole part was copied from https://github.com/all-of-us/workbench/blob/fcac632a7d5287b30a159ee71a810c46f2974d79/api/src/main/java/org/pmiops/workbench/exfiltration/EgressEventServiceImpl.java#L84L100, somehow I grouped both into 1 because user should not be empty?
| @@ -280,6 +290,18 @@ protected void disableUser(DbUser user) { | |||
| stopUserRuntimesAndApps(user.getUsername()); | |||
| } | |||
|
|
|||
| protected void disableUserVwbDataAccess(DbUser user) { | |||
| userService.updateUserWithRetries( | |||
There was a problem hiding this comment.
maybe just call disableUser here instead of duplicating the code?
There was a problem hiding this comment.
i will be adding logic in my next PR here. So I probably will leave it as it and come back to modify soon
Thanks. That codify is an exising issues comes from parent class, don't know how to fix it without a large refactor |
Initial batch of egress processing. There would be few followup for email and jira.
This is incomplete work, but for now, everything is protected by feature flag
PR checklist
[risk=no|low|moderate|severe]in the PR title as outlined in CONTRIBUTING.md.