Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[risk=low][no ticket] Bump express to upgrade path-to-regexp and unforce cookie #8991

Merged
merged 1 commit into from
Jan 2, 2025
Merged

[risk=low][no ticket] Bump express to upgrade path-to-regexp and unforce cookie #8991

merged 1 commit into from
Jan 2, 2025

Conversation

jmthibault79
Copy link
Collaborator

@jmthibault79 jmthibault79 commented Dec 9, 2024 •
edited
Loading

Tested locally with no obvious problems.

PR checklist

  • I have included an issue ID or "no ticket" in the PR title as outlined in CONTRIBUTING.md.
  • I have included a risk tag of the form [risk=no|low|moderate|severe] in the PR title as outlined in CONTRIBUTING.md.
  • I have manually tested this change and my testing process is described above.
  • This change includes appropriate automated tests, and I have documented any behavior that cannot be tested with code.
  • I have added explanatory comments where the logic is not obvious.
  • One or more of the following is true:
    • This change is intended to complete a JIRA story, so I have checked that all AC are met for that story.
    • This change fixes a bug, so I have ensured the steps to reproduce are in the Jira ticket or provided above.
    • This change impacts deployment safety (e.g. removing/altering APIs which are in use), so I have documented the impacts in the description.
    • This change includes a new feature flag, so I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later.
    • This change modifies the UI, so I have taken screenshots or recordings of the new behavior and notified the PO and UX designer in Slack.
    • This change modifies API behavior, so I have run the relevant E2E tests locally because API changes are not covered by our PR checks.
    • None of the above apply to this change.

@jmthibault79 jmthibault79 marked this pull request as ready for review January 2, 2025 15:44
@jmthibault79 jmthibault79 requested a review from Qi77Qi January 2, 2025 16:04
Qi77Qi
Qi77Qi approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@Qi77Qi Qi77Qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jmthibault79 jmthibault79 merged commit b3fb3ec into main Jan 2, 2025
7 checks passed
jmthibault79 added a commit that referenced this pull request Jan 2, 2025
@jmthibault79
[risk=low][no ticket] Bump express to unforce cookie (#8991)
b3fb3ec
@jmthibault79 jmthibault79 deleted the joel/unforce branch January 2, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qi77Qi Qi77Qi Qi77Qi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmthibault79 @Qi77Qi